Convert Omnilink build to the new openhab build system.

[boc-tothefuture]

Details see here

@digitaldan - I believe you tackling this one.

[digitaldan]

@boc-tothefuture I have this done, but am running into one problem. It looks like the version of jomnilink in this project (jomnilink-1.3.0-SNAPSHOT.jar) is a fork from my jomnilink project, but i can not find the source of it anywhere. I am trying to use the one being published maven repo so we don't have to include the lib directory anymore. Do you know where this is? And can those changes be added back to my project so it can be published to maven central?

[digitaldan]

ah, found it https://github.com/boc-tothefuture/jomnilink/commits/locks , for some reason this was not shown as an active branch and i missed it when poking around forks. Can you make a PR ? Thanks!

[boc-tothefuture]

@digitaldan PR submitted.

[boc-tothefuture]

@digitaldan -
Are we now building against 2.5 then? If using the new build system - I am assuming that is the case.

[boc-tothefuture]

@digitaldan - now that the openhab master I can start working on this binding again, where did you end up with the new build system?

[craigham]

@boc-tothefuture have you got a build environment working within the new system? I have been holding off investing the time in setting one up until things have settled.

thanks

[boc-tothefuture]

@craigham - No not yet. Now that 2.5M2 is released I think things are stable enough to make progress. I think @digitaldan already did some work in this space so I was hoping to not start from scratch.

[digitaldan]

It’s been so long I can’t remember :-) let me check today , but I have converted a few bindings to the new build system, should not take me long either way.

On Sat, Aug 24, 2019 at 7:24 AM boc-tothefuture ***@***.***> wrote: @craigham <https://github.com/craigham> - No not yet. Now that 2.5M2 is released I think things are stable enough to make progress. I think @digitaldan <https://github.com/digitaldan> already did some work in this space so I was hoping to not start from scratch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#138?email_source=notifications&email_token=AAOQY6ILEOJHZUSVEEVTQUTQGEK5RA5CNFSM4HCNZEF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B6FUQ#issuecomment-524542674>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOQY6IEVRFY7YHSRZ325DTQGEK5RANCNFSM4HCNZEFQ> .

-- Sent from my mobile.

[digitaldan]

I'm looking at this today FYI. I do have a branch converted to the new BND build system , but tis a few months old and i need to verify its still valid.

[digitaldan]

So @craigham you merged my PR #144 back in April, this moved the binding to the new build system. I just tested it ( mvn -DskipChecks=true -Denforcer.skip=true clean install) and it build and runs on my system still. I did notice I forgot to add this to the /bundles/pom.xml, but that would only effect when building all bindings, I'll open a PR today to fix that.

Also I think we should open up a "release" ticket to track work that needs to be done to release. For example, we need to add null annotations ( https://www.openhab.org/v2.4/docs/developer/development/conventions.html ) , update license headers, fix compiler checks errors, etc... before submitting for review.

[boc-tothefuture]

@digitaldan -
We have a released ticket here
I have added the items you mentioned.

[boc-tothefuture]

@digitaldan -
It sounds like this was merged in April.. can I close this issue?

[digitaldan]

We have a released ticket here

DOH!

[digitaldan]

It sounds like this was merged in April.. can I close this issue?

i think so, unless the build is not working for you.