-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Adding Discrete Approximation of VAR Methods #640
Merged
Merged
Changes from 18 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
4ae4ee5
Add discrete_var
Smit-create 4709925
Add suggestions by @crondonm
Smit-create 8295961
Add discrete_var in approximation
Smit-create 2e7526d
Add tests
Smit-create 84e751d
add suggestions 1, 2, 5 by @jstac
shlff ba09926
Add docs of Pi and S in output.
Smit-create cc5217c
Remove row_major argument and use cartesian from gridtools
Smit-create c26d265
Modify tests to drop row_major
Smit-create 00f457e
Rename Pi to P
Smit-create 740cf73
use mlinspace
shlff 6c50e1e
Merge branch 'VAR-approximation' of https://github.com/crondonm/Quant…
oyamad 745c0d4
Implement discrete_var using quantecon functions
oyamad 6e3315f
Merge branch 'main' into VAR-approximation-2
oyamad f4ebd6f
Use `fit_discrete_mc`
oyamad 7f7eec4
Remove unused import
oyamad 9515951
Remove unused import
oyamad bb91864
adjust test and docstring
HumphreyYang 03e1a8d
Edit docstring
oyamad ac83c52
Import _lss and _matrix_eqn
oyamad f8e9551
add new tests and bug fixing
HumphreyYang 4317827
Merge branch 'VAR-approximation-2' into VAR-approximation
HumphreyYang b7f4497
add tests for non-square C
HumphreyYang 15c4f78
adjust docstring
HumphreyYang 496942d
Minor edits in docstring
oyamad 4392ef9
adjust based on review
HumphreyYang 0a8a7f6
update docstring
HumphreyYang a85a6cd
set unit Cov for t-distribution
HumphreyYang d4b5afd
Merge branch 'VAR-approximation' of https://github.com/crondonm/Quant…
oyamad 08dd321
CI: Workaround for windows (#694)
oyamad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function be named
disrete_VAR
givenvar
is an acronym for Vector Auto Regression (VAR).PEP8
has a blanket rule for lower case function names so may not be a great idea.discrete_var
just reminds me ofdiscrete variable
.