Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix dtype in cartesian #659

Merged
merged 2 commits into from
Dec 1, 2022
Merged

FIX: Fix dtype in cartesian #659

merged 2 commits into from
Dec 1, 2022

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Nov 29, 2022

Current code:

>>> nodes = [[0, 1], [2.3, 4.5]]
>>> qe.cartesian(nodes)
array([[0, 2],
       [0, 4],
       [1, 2],
       [1, 4]])

This PR:

>>> nodes = [[0, 1], [2.3, 4.5]]
>>> qe.cartesian(nodes)
array([[0. , 2.3],
       [0. , 4.5],
       [1. , 2.3],
       [1. , 4.5]])

@coveralls
Copy link

coveralls commented Nov 29, 2022

Coverage Status

Coverage increased (+0.05%) to 95.281% when pulling 1494995 on fix-gridmake into 366c558 on master.

@oyamad oyamad added the ready label Nov 29, 2022
@oyamad oyamad merged commit fcde8c9 into master Dec 1, 2022
@oyamad oyamad deleted the fix-gridmake branch December 1, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants