Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 2.0.0 #52

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Support JupyterLab 2.0.0 #52

merged 1 commit into from
Mar 19, 2020

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Mar 4, 2020

Fixes #51.

After this PR is merged, future releases of this extension will now require JupyterLab 2, but if JupyterLab 1 is used an old versions of this package can still be used automatically instead.

@jasongrout
Copy link
Contributor

I think it is fine to only support jlab 2 moving forward.

@consideRatio
Copy link
Contributor Author

consideRatio commented Mar 5, 2020

@jasongrout can you help me validate my understanding:

Assume we have a NPM package with two versions, version 0.1.0 with JupyterLab 1 dependencies, and version 0.2.0 with JupyterLab 2 dependencies. If I had JupyterLab 1 installed, and did jupyter labextension install <name>, it would install version 0.1 that was the latest version compatible with JupyterLab 1 dependencies?

@jasongrout
Copy link
Contributor

it would install version 0.1 that was the latest version compatible with JupyterLab 1 dependencies?

Yes. JupyterLab is smart enough to go back through the published versions of a package and install the latest compatible version.

@granitDev
Copy link

As a user of Jupyter Labs, I would like to request this pull request be merged in as soon as possible. I would like to have this functionality back in version 2.

Thank you.

@jasongrout
Copy link
Contributor

CC @wolfv

@wolfv wolfv merged commit c3ea049 into QuantStack:master Mar 19, 2020
@wolfv
Copy link
Member

wolfv commented Mar 19, 2020

Thanks everyone!

@consideRatio
Copy link
Contributor Author

Thanks @wolfv!

This will be part of a release > 0.6.0: https://www.npmjs.com/package/jupyterlab-drawio

bollwyvl added a commit to bollwyvl/jupyterlab-drawio that referenced this pull request Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JupyterLab 2.0.0
4 participants