Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed file and fix mypy, improve pre-commit configuration #124

Merged
merged 5 commits into from
May 22, 2024

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented May 21, 2024

No description provided.

Copy link

github-actions bot commented May 21, 2024

(benchmark 9187445539 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
sklearn rf 20M 23.4 MiB / 3.0 MiB / 7.67 x 0.01 s / 0.03 s / 2.27 x 0.02 s / 0.06 s / 2.70 x
sklearn rf 20M lzma 6.5 MiB / 2.0 MiB / 3.21 x 10.16 s / 0.77 s / 0.08 x 0.41 s / 0.15 s / 0.37 x
sklearn rf 200M 238.8 MiB / 30.8 MiB / 7.75 x 0.15 s / 0.22 s / 1.51 x 0.21 s / 0.39 s / 1.81 x
sklearn rf 200M lzma 48.8 MiB / 14.8 MiB / 3.29 x 74.39 s / 14.55 s / 0.20 x 3.18 s / 1.15 s / 0.36 x
sklearn rf 1G 1302.2 MiB / 168.0 MiB / 7.75 x 0.81 s / 1.16 s / 1.42 x 1.23 s / 1.92 s / 1.56 x
sklearn rf 1G lzma 262.4 MiB / 99.1 MiB / 2.65 x 376.67 s / 83.09 s / 0.22 x 16.39 s / 6.86 s / 0.42 x
sklearn gb 2M 2.5 MiB / 1.1 MiB / 2.16 x 0.06 s / 0.23 s / 3.60 x 0.03 s / 0.26 s / 8.41 x
sklearn gb 2M lzma 0.6 MiB / 0.2 MiB / 3.76 x 0.82 s / 0.41 s / 0.51 x 0.07 s / 0.24 s / 3.37 x
lgbm gbdt 2M 2.6 MiB / 1.0 MiB / 2.78 x 0.05 s / 0.18 s / 3.88 x 0.01 s / 0.09 s / 10.19 x
lgbm gbdt 2M lzma 0.9 MiB / 0.5 MiB / 1.90 x 1.16 s / 0.40 s / 0.34 x 0.06 s / 0.11 s / 2.03 x
lgbm gbdt 5M 5.3 MiB / 1.9 MiB / 2.81 x 0.09 s / 0.36 s / 3.88 x 0.02 s / 0.18 s / 10.59 x
lgbm gbdt 5M lzma 1.7 MiB / 0.8 MiB / 1.96 x 2.47 s / 0.79 s / 0.32 x 0.11 s / 0.22 s / 2.12 x
lgbm gbdt 20M 22.7 MiB / 7.6 MiB / 3.00 x 0.39 s / 1.48 s / 3.78 x 0.07 s / 0.73 s / 10.16 x
lgbm gbdt 20M lzma 6.3 MiB / 3.0 MiB / 2.09 x 15.18 s / 3.58 s / 0.24 x 0.41 s / 0.90 s / 2.17 x
lgbm gbdt 100M 101.1 MiB / 33.0 MiB / 3.06 x 1.78 s / 6.61 s / 3.71 x 0.36 s / 14.19 s / 39.56 x
lgbm gbdt 100M lzma 25.6 MiB / 10.6 MiB / 2.41 x 70.98 s / 18.31 s / 0.26 x 1.67 s / 3.82 s / 2.28 x
lgbm rf 10M 10.9 MiB / 3.2 MiB / 3.46 x 0.17 s / 0.42 s / 2.45 x 0.04 s / 0.27 s / 6.61 x
lgbm rf 10M lzma 0.7 MiB / 0.4 MiB / 1.86 x 1.42 s / 0.65 s / 0.46 x 0.08 s / 0.30 s / 3.67 x

@pavelzw pavelzw marked this pull request as ready for review May 21, 2024 19:54
@pavelzw pavelzw requested a review from 0xbe7a May 21, 2024 19:54
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@pavelzw pavelzw merged commit be17763 into main May 22, 2024
19 checks passed
@pavelzw pavelzw deleted the py-typed branch May 22, 2024 10:54
@pavelzw pavelzw added the enhancement New feature or request label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants