Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version warnings #24

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add version warnings #24

merged 1 commit into from
Mar 17, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Mar 16, 2023

No description provided.

@pavelzw pavelzw requested a review from YYYasin19 March 16, 2023 16:41
@github-actions
Copy link

(benchmark 4439466212 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
RandomForestRegressor 77.2 MiB / 12.7 MiB / 6.08 x 0.07 s / 0.10 s / 1.42 x 0.08 s / 0.09 s / 1.07 x
GradientBoostingRegressor 2.2 MiB / 1.1 MiB / 2.12 x 0.03 s / 0.16 s / 5.31 x 0.03 s / 0.11 s / 3.34 x
LGBMRegressor gbdt 5.3 MiB / 1.9 MiB / 2.74 x 0.17 s / 0.39 s / 2.34 x 0.03 s / 0.30 s / 11.80 x
LGBMRegressor gbdt large 5.3 MiB / 1.9 MiB / 2.74 x 0.16 s / 0.39 s / 2.37 x 0.03 s / 0.30 s / 11.41 x
LGBMRegressor rf 1.6 MiB / 0.5 MiB / 3.30 x 0.05 s / 0.08 s / 1.83 x 0.01 s / 0.07 s / 12.68 x



def check_version(version: str):
if version != slim_trees_version:
Copy link
Contributor

@YYYasin19 YYYasin19 Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could think about matching just the first two version numbers here, e.g. 2.3.1 and 2.3.2 would still work together. Otherwise, every minor patch and release causes all existing models to be invalid, although we didn't change anything on the compression side of things.

The schema would be
A.B.C where
C = some utils changed, nothing user-facing, nothing regarding the data, e.g. just speed-up
B = something with the compression changed
A = something with the user interface changed

I'm happy to merge like this right now, though, since we're in an early alpha and shouldn't have to worry about this too soon. :)

Copy link
Contributor

@YYYasin19 YYYasin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎉

@pavelzw pavelzw merged commit 5694c78 into main Mar 17, 2023
@pavelzw pavelzw deleted the version-warnings branch March 17, 2023 16:20
@pavelzw pavelzw added the enhancement New feature or request label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants