Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark script, fix regex, remove N806 #9

Merged
merged 17 commits into from
Feb 22, 2023
Merged

Add benchmark script, fix regex, remove N806 #9

merged 17 commits into from
Feb 22, 2023

Conversation

jonashaag
Copy link
Contributor

Adds a script that outputs a table like

Model Baseline Size Our Size Size Reduction Baseline Loading Time Our Loading Time Slowdown
sklearn RandomForestRegressor 181.2 MiB 24.1 MiB 7.5 x 0.0 s 0.1 s 4.2 x
lightgbm LGBMRegressor 0.3 MiB 0.1 MiB 3.1 x 0.0 s 0.0 s 10.7 x

Feel free to change this however you prefer. Not sure if I will find more time to work on this.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

(benchmark 4245116652 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
RandomForestRegressor 77.2 MiB / 12.5 MiB / 6.16 x 0.07 s / 0.11 s / 1.53 x 0.08 s / 0.09 s / 1.08 x
LGBMRegressor gbdt 0.3 MiB / 0.1 MiB / 2.64 x 0.00 s / 0.02 s / 3.44 x 0.00 s / 0.02 s / 12.02 x
LGBMRegressor rf 1.6 MiB / 0.5 MiB / 3.30 x 0.05 s / 0.08 s / 1.80 x 0.01 s / 0.08 s / 13.99 x

@pavelzw
Copy link
Member

pavelzw commented Feb 22, 2023

Closes #6

@pavelzw
Copy link
Member

pavelzw commented Feb 22, 2023

It could be interesting to integrate benchmark-action. But I think for now this should be enough...

@pavelzw pavelzw changed the title Add benchmark script Add benchmark script, fix regex, remove N806 Feb 22, 2023
@pavelzw pavelzw merged commit d4ccb9b into main Feb 22, 2023
@pavelzw pavelzw deleted the benchmark branch February 22, 2023 17:05
YYYasin19 pushed a commit that referenced this pull request Mar 4, 2023
@pavelzw pavelzw added enhancement New feature or request ci Changes in the CI configuration labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes in the CI configuration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants