Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff-format and support for python 3.12 #90

Merged
merged 4 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,22 @@ changelog:
exclude:
labels:
- ignore for release
- ci
categories:
- title: New features
- title: New features
labels:
- enhancement
- title: Bug fixes
- title: 🐛 Bug fixes
labels:
- bug
- title: Documentation
- title: 📝 Documentation
labels:
- documentation
- title: Dependencies
- title: ⬆️ Dependencies
labels:
- dependencies
- title: Other changes
- title: 🚀 CI
labels:
- ci
- title: 🤷🏻 Other changes
labels:
- '*'
7 changes: 3 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- { PYTHON_VERSION: '3.9', SKLEARN_VERSION: '', LGBM_VERSION: '' }
- { PYTHON_VERSION: '3.10', SKLEARN_VERSION: '', LGBM_VERSION: '' }
- { PYTHON_VERSION: '3.11', SKLEARN_VERSION: '', LGBM_VERSION: '' }
- { PYTHON_VERSION: '3.12', SKLEARN_VERSION: '', LGBM_VERSION: '' }
steps:
- uses: actions/checkout@v4
- name: Set up conda env
Expand All @@ -57,13 +58,11 @@ jobs:
${{ matrix.SKLEARN_VERSION }}${{ matrix.LGBM_VERSION }}

linux-unittests-pixi:
name: "Unit tests Pixi - Python ${{ matrix.PYTHON_VERSION }}"
name: Unit tests Pixi
timeout-minutes: 15
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
PYTHON_VERSION: ['3.11']
steps:
- uses: actions/checkout@v4
- uses: prefix-dev/[email protected]
Expand All @@ -74,7 +73,7 @@ jobs:
uses: pavelzw/pytest-action@v2
with:
custom-pytest: pixi run test
report-title: "Unit tests Linux Pixi - Python ${{ matrix.PYTHON_VERSION }}"
report-title: Unit tests Linux Pixi

pre-commit: # todo switch to pre-commit.ci
name: "Pre-commit checks"
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,3 @@ mlruns

# pixi
.pixi
# this is a library so we don't include pixi.lock
pixi.lock
10 changes: 2 additions & 8 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,10 @@ repos:
- id: trailing-whitespace
- id: check-toml
- repo: https://github.com/quantco/pre-commit-mirrors-ruff
rev: 0.0.291
rev: 0.1.2
hooks:
- id: ruff-conda
- repo: https://github.com/quantco/pre-commit-mirrors-black
rev: 23.9.1
hooks:
- id: black-conda
args:
- --safe
- --target-version=py38
- id: ruff-format-conda
- repo: https://github.com/quantco/pre-commit-mirrors-mypy
rev: 1.5.1
hooks:
Expand Down
Loading