Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter matches on raised errors in test suite #1707

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Feb 15, 2024

Closes #1700.

Partially addresses #1708.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Stricter DFTB+ tests Stricter matches on raised errors in test suite Feb 15, 2024
@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) February 15, 2024 17:28
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c9eb1e) 99.43% compared to head (8cecc9a) 99.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
- Coverage   99.43%   99.33%   -0.11%     
==========================================
  Files          76       76              
  Lines        2997     2988       -9     
==========================================
- Hits         2980     2968      -12     
- Misses         17       20       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen merged commit f5d43ed into main Feb 15, 2024
21 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the dftb_tests branch February 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ensure test coverage of missing quacc.recipes.dftb._base.py lines
1 participant