Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ESPRESSO compatible with chdir: False #1822

Merged

Conversation

tomdemeyere
Copy link
Contributor

@tomdemeyere tomdemeyere commented Mar 3, 2024

Summary of Changes

Fix for #1807

Please do not hesitate to ping me on this kind of issues

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (4ee367d) to head (cad026a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1822   +/-   ##
=======================================
  Coverage   99.42%   99.43%           
=======================================
  Files          80       80           
  Lines        3156     3159    +3     
=======================================
+ Hits         3138     3141    +3     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen
Copy link
Member

Fantastic. Thank you for taking care of this! 🙏

@Andrew-S-Rosen Andrew-S-Rosen merged commit 72d4e00 into Quantum-Accelerators:main Mar 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants