Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for ~-based paths in RESULTS_DIR and SCRATCH_DIR, and don't make a symlink if not necessary #984

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Allow for ~-based paths in RESULTS_DIR and SCRATCH_DIR, and don't make a symlink if not necessary #984

merged 9 commits into from
Sep 26, 2023

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Sep 26, 2023 •
edited
Loading

Fixes:

  • Allows for proper setting of ~/-based paths for RESULTS_DIR and SCRATCH_DIR
  • Doesn't create a redundant symlink file when RESULTS_DIR == SCRATCH_DIR.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Better path handling Allow for ~-based paths in RESULTS_DIR and SCRATCH_DIR, and don't make a symlink if not necessary Sep 26, 2023
@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) September 26, 2023 03:25
@Andrew-S-Rosen Andrew-S-Rosen merged commit 8d60c99 into main Sep 26, 2023
16 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the path_handle branch September 26, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Andrew-S-Rosen