Support spaces in Linux executable name #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that nothing has changed after your commit. It would probably be better to just make a more correct script and add a line terminator to the end of the script. Just change: to |
|
I tried to remove the trailing newline but apparently GitHub didn't let me do so. Will add the newline to the generator. |
|
Your fixes will be available within an hour in version 1.4.4.1. You can download it in the snap store or in the cqtdeployer update manager. Thanks for work) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetaFileManager works correctly on Windows for executable names with spaces in them but on Linux the quote needs to be moved.
New version of PR #380 which is now done on the 1.4 branch and also fixes the unit test.