Skip to content

Commit

Permalink
Hotfix release.yml (#514)
Browse files Browse the repository at this point in the history
A tiny fix to `release.yml`. 
I've thought that default input values are going to be used, but
apparently that's not the case and for jobs triggered by a push to
branch `github.event.inputs` is empty

Ref: https://github.com/orgs/community/discussions/26322
  • Loading branch information
mieciu authored Jul 11, 2024
1 parent 0ff5d8d commit acfc980
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ jobs:
uses: docker/build-push-action@v6
with:
context: ${{ matrix.module }}/.
# when called from the main branch, `github.event.inputs.VERSION` doesn't use default value and is just empty
tags: |
europe-docker.pkg.dev/metal-figure-407109/quesma-nightly/quesma:${{ github.sha }}
europe-docker.pkg.dev/metal-figure-407109/quesma-nightly/quesma:${{ github.event.inputs.VERSION }}
quesma/quesma:${{ github.event.inputs.VERSION }}
europe-docker.pkg.dev/metal-figure-407109/quesma-nightly/quesma:${{ github.event.inputs.VERSION || 'latest' }}
quesma/quesma:${{ github.event.inputs.VERSION || 'latest' }}
quesma/quesma:latest
# Pushes to GCR only for `main` branch builds, unless set explicitly in the job input
push: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event.inputs.PUSH }}
Expand Down

0 comments on commit acfc980

Please sign in to comment.