Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index <-> tables mappings : fixing field caps and search index resolving #544

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Index <-> tables mappings : fixing field caps and search index resolving #544

merged 2 commits into from
Jul 19, 2024

Conversation

pdelewski
Copy link
Contributor

@pdelewski pdelewski commented Jul 18, 2024 •
edited
Loading

This PR implements some missing pieces to connect index <-> tables mappings e2e like field caps.

According configuration all request for kibana_sample_data_flights go to big_kibana_common_table

indexMappings:
  big_kibana_common_table:
    sourceIndexes: ["kibana_sample_data_flights"]
image image

@pdelewski pdelewski force-pushed the index-mappings-missing-logic branch from 7ec5b6e to ae0f2de Compare July 18, 2024 13:17
@pdelewski pdelewski force-pushed the index-mappings-missing-logic branch from ae0f2de to b63183e Compare July 18, 2024 13:28
@pdelewski pdelewski changed the title Fixing field caps and search index resolving according to mappings Index <-> tables mappings : fixing field caps and search index resolving Jul 18, 2024
@pdelewski pdelewski marked this pull request as ready for review July 18, 2024 14:16
@pdelewski pdelewski requested a review from a team as a code owner July 18, 2024 14:16
@pdelewski pdelewski force-pushed the index-mappings-missing-logic branch from 7adb607 to 8fd1d31 Compare July 18, 2024 14:19
@pdelewski pdelewski force-pushed the index-mappings-missing-logic branch from 8fd1d31 to 48ce9aa Compare July 18, 2024 14:21
@pdelewski pdelewski added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit f091838 Jul 19, 2024
5 checks passed
@pdelewski pdelewski deleted the index-mappings-missing-logic branch July 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelanarius avelanarius avelanarius approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelewski @avelanarius