Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we have this logic to ignore creating TLS-based connections when we get specific TLS-related errors (assuming that plaintext connection should be used).
However, when we start Quesma while ClickHouse is dead, aforementioned logic doesn't work and we don't fallback to non-TLS connection properly, as the error is just "connection refused":
So eventually when plaintext ClickHouse comes up, the pool will keep failing repeatedly with
tls: first record does not look like a TLS handshake
.The proposed remediation is to just allow explicitly disabling TLS via configuration.
Alternative approach would be to derive this property by looking at port numbers:
of course being very verbose in logs about Quesma's choice.