Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_date_histogram aggregation #893

Merged
merged 15 commits into from
Oct 31, 2024
Merged

auto_date_histogram aggregation #893

merged 15 commits into from
Oct 31, 2024

Conversation

trzysiek
Copy link
Member

@trzysiek trzysiek commented Oct 15, 2024 •
edited
Loading

Only bucket_nr=1 case is handled, key value for auto_date_histogram's only bucket is extracted from where clause via a simple visitor.

jakozaur
jakozaur reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jakozaur jakozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some changes are needed.

quesma/model/where_visitor.go Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024 •
edited
Loading

Deploying quesma with  Cloudflare Pages  Cloudflare Pages

Latest commit: c66e2bc
Status: ✅  Deploy successful!
Preview URL: https://5aad3665.quesma.pages.dev
Branch Preview URL: https://auto-date-histogram.quesma.pages.dev

View logs

@trzysiek trzysiek changed the title [merge other PR first] auto_date_histogram aggregation [merge #923 first] auto_date_histogram aggregation Oct 29, 2024
@trzysiek trzysiek changed the title [merge #923 first] auto_date_histogram aggregation auto_date_histogram aggregation Oct 29, 2024
@trzysiek trzysiek marked this pull request as ready for review October 30, 2024 22:51
@trzysiek trzysiek requested a review from a team as a code owner October 30, 2024 22:51
jakozaur
jakozaur approved these changes Oct 31, 2024
View reviewed changes
quesma/model/bucket_aggregations/auto_date_histogram.go Outdated Show resolved Hide resolved
quesma/model/bucket_aggregations/auto_date_histogram.go Outdated Show resolved Hide resolved
quesma/model/where_visitor.go Outdated Show resolved Hide resolved
quesma/queryparser/pancake_transformer.go Outdated Show resolved Hide resolved
quesma/queryparser/pancake_transformer.go Show resolved Hide resolved
@trzysiek trzysiek mentioned this pull request Oct 31, 2024
Open
@trzysiek trzysiek added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 61339a9 Oct 31, 2024
6 checks passed
@trzysiek trzysiek deleted the auto-date-histogram branch October 31, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakozaur jakozaur jakozaur approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trzysiek @jakozaur