table_resolver refactor - introduce patternSplitter, decisionMerger #925
+276
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
force-pushed
the
table_resolver_refactor
branch
6 times, most recently
from
61cdda1
to
0bfe29b
Compare
avelanarius
changed the title
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
|
I really like logic :) |
pdelewski
reviewed
Nov 5, 2024
pdelewski
reviewed
Nov 5, 2024
nablaone
reviewed
Nov 6, 2024
quesma/table_resolver/rules.go
Outdated
| if lhsClickhouse, ok := connDecisionLhs.(*ConnectorDecisionClickhouse); ok { | ||
| if lhsClickhouse.ClickhouseTableName != rhsClickhouse.ClickhouseTableName { | ||
| return nil, &Decision{ | ||
| Reason: "Inconsistent ClickHouse table usage", |
There was a problem hiding this comment.
We should add more details here.
There was a problem hiding this comment.
Fixed in last commit - made the reason (and corresponding Err) more clear.
quesma/table_resolver/rules.go
Outdated
| } else { | ||
| if !reflect.DeepEqual(lhsClickhouse, rhsClickhouse) { | ||
| return nil, &Decision{ | ||
| Reason: "Inconsistent ClickHouse table usage", |
There was a problem hiding this comment.
The same reason is returned above. There is no way to distinguish which one rule has been fired.
There was a problem hiding this comment.
Fixed in last commit - made the reason (and corresponding Err) more clear.
quesma/table_resolver/rules.go
Outdated
| } | ||
| if !foundMatching { | ||
| return nil, &Decision{ | ||
| Reason: "Inconsistent connectors", |
There was a problem hiding this comment.
As above, we need more details here.
There was a problem hiding this comment.
Fixed in last commit - made the reason (and corresponding Err) more clear.
A/B testing is turned on in the configuration by specifying two targets: ClickHouse and Elastic (`target: [ch, es]`). table_resolver correctly handles it for single index case, but it's not working correctly for the pattern case (even if the pattern matches only a single index with A/B testing requested). Adding a (skipped) test for such case (a proper fix needs some discussion).
avelanarius
force-pushed
the
table_resolver_refactor
branch
from
69b408a
to
7716b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way patterns (wildcards such as
logs*) are handled bytable_resolver.Previously, many
table_resolverrules had two code paths - one code path for a single index (e.g.logs1) and one code path for patterns (e.g.logs1,logs2orlogs*), making those rules more complicated. Moreover, one rulemakeCheckIfPatternMatchesAllConnectorswas the primary one to handle patterns and it contained fragments of other rules.This PR introduces
patternSplitter,decisionMerger. Thetable_resolvernow works like this:patternSplittersplits a pattern (e.g.logs*) into concrete single indexes (e.g.logs1,logs2)decisionMergermerges decisions of single indexes, making sure that the decisions are compatible. It yields a single decision.