-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target config extended configuration #945
Conversation
d54638c
to
d6945ea
Compare
useCommonTable: false | ||
kibana_sample_data_flights: | ||
target: | ||
- my-clickhouse-data-source: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some way to avoid having to write {}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. It seems to be yaml syntax specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new configuration syntax looks OK, but I think this looks strange:
kibana_sample_data_flights:
target:
- my-clickhouse-data-source: {}
and it'd be great if something like this was possible instead:
kibana_sample_data_flights:
target:
- my-clickhouse-data-source
Let me check that again. Ok, this seems to be working. I think I made some mistake previously. I will update config |
This PR implements new variant of
target
configuration where it's a list not an array and can have more attributes (potentially in the future)Current variant is still supported and is a fallback in the case extended version is missing
Below
is equivalent of
PR contains a bit of duplicated code, something that I would prefer fix in next PR.