Improve connection doctor and validation of connection URLs #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
This PR improves the validation of connection URLs in configuration, giving clearer error messages to the user and the expected format of the connection string. Related to that, RemoteLogDrainUrl and QuesmaInternalTelemetryUrl now can't be provided in the config - they were overwritten by hardcoded constants either way. Additionally, ClickHouse connection doctor is improved: - If connection succeeded it suggests making sure that username/password is correct - It now skips TLS trial connections if the user disabled TLS in the config (and informs of that fact) - It tries default ports in more cases This PR is extracted from larger PR QuesmaOrg#938.
avelanarius
force-pushed
the
better-conn-string-validation
branch
from
bc58fb1
to
7ac4d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the validation of connection URLs in configuration, giving clearer error messages to the user and the expected format of the connection string.
Related to that, RemoteLogDrainUrl and QuesmaInternalTelemetryUrl now can't be provided in the config - they were overwritten by hardcoded constants either way.
Additionally, ClickHouse connection doctor is improved:
This PR is extracted from larger PR #938.