Fix mod hash computation #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce. This should fix the transform cache being recomputed every launch due to system mods not being skipped.
TheGlitch76
reviewed
Aug 27, 2023
| return Arrays.copyOf(hash, HASH_LENGTH); | ||
| } | ||
|
|
||
| private static byte[] computeRecursiveHash0(Path path) throws IOException { |
There was a problem hiding this comment.
Question--will this report as a "SHA" hash in the mod table?
There was a problem hiding this comment.
Good question! No, actually - the mod table doesn't use ModLoadOption.computeOriginHash at all, as it instead uses computeNormalHash for every source path.
TheGlitch76
approved these changes
Sep 5, 2023
TheGlitch76
pushed a commit
that referenced
this pull request
Sep 8, 2023
|
Merged manually with 94e5ca7 as you've disabled my ability to push directly to your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the transform cache being recomputed every launch due to system mods not being skipped.