-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for adding Entity-renaming DataFixes #213
base: 1.19
Are you sure you want to change the base?
Conversation
Note:
|
I think these
|
hmm, should a test for this be added to testmodV3 as well? |
AH! I forgot an import... like I said, I'm working with the webeditor here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we do wanna kill the DFU API later, it doesn't hurt too much to add a few things until it's replacement comes
just a heads up: I'm currently swamped with work for at least a month. So if testing this is a blocking task, then I won't have time to do it for a while |
is there any existing discussion on this planned replacement I can follow? is it being tracked in a GH issue and/or on the discord server? |
Leo has discussed some potential ideas for the replacement on the toolchain server's #forum-qsl forum channel |
Anyway, I'm fast-tracking this PR's FCP to Monday, December 5th |
I'd advise against initiating FCP, because it's currently untested and I'd hate to be the author of potentially non-functional code in QSL. I really don't know if it works, I just know it compiles. Doesn't the tag |
I'm not sure how lenient we are for betas to potentially have bugs, and I suppose that may be a part of an efficient development cycle, but I feel anything involving the DFU needs to have extra care taken because one of the consequences of any bugs/mistakes here includes world corruption (specifically, messing up all entities in the world) |
After some thinking and considering the IRL circumstances, I'm delaying the merging of this PR until I'm able to test it myself; After all, it isn't really as urgent as other merge-before-1.19.3 PRs since DFU API is disabled on 1.19.3 |
I noticed
SimpleFixes
doesn't have a method for renaming Entities like it does for Items, Blocks, and Biomes. This PR adds that.