-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19.4 feature backports #347
1.19.4 feature backports #347
Commits on Sep 28, 2023
-
Implement Dynamic Registry Flags.
- Currently, only one flag, `OPTIONAL`, exists. - Modified DynamicRegistrySyncMixin in order to implement these flags. Due to the Redirect mixin header used to implement the flag filtering being taken directly from FAPI, the header of DynamicRegistrySyncMixin was changed to mention FabricMC copyright, in accordance with QSL contribution rules in CONTRIBUTING.md
Configuration menu - View commit details
-
Copy full SHA for 64ce1e5 - Browse repository at this point
Copy the full SHA 64ce1e5View commit details -
Implement Dynamic Registry Flags p2
- Modify DynamicRegistryFlagManager to use Identifiers over RegistryKeys internally, in order to avoid generic-related jank. - Fix mixin ported from FAPI by correcting method target string to use Quilt Mappings. - Implement very basic tests.
Configuration menu - View commit details
-
Copy full SHA for 5d0d36a - Browse repository at this point
Copy the full SHA 5d0d36aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4cb501 - Browse repository at this point
Copy the full SHA a4cb501View commit details -
Configuration menu - View commit details
-
Copy full SHA for cefd32a - Browse repository at this point
Copy the full SHA cefd32aView commit details -
Implemented some changes suggested by Pyrofab
- Added protected helper method DynamicMetaRegistryImpl#isFrozen for use in DynamicRegistryFlagManager - Added DynamicMetaRegistryImpl#LOGGER with the name "quilt_dynamic_registries" as a logger for catching exceptions related to the setting of flags - Removed the ability to disable dynamic registry flags, changed the signature of the related flag-enabling methods from enableFlag -> setFlag (on both DynamicRegistryFlag and DynamicRegistryFlagManager) - DynamicRegistryFlagManager#setFlag now throws an IllegalStateException if a mod attempts to enable a flag when dynamic registries are frozen. This is caught and printed to the logger mentioned prior in DynamicRegistryFlag calls - Added varargs for setting DynamicRegistryFlag values on dynamic registry creation - Improved DynamicRegistryFlag#OPTIONAL javadocs slightly
Configuration menu - View commit details
-
Copy full SHA for 120c5cf - Browse repository at this point
Copy the full SHA 120c5cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8807ac - Browse repository at this point
Copy the full SHA c8807acView commit details -
One of them needs a more specific wording change, so it's going to be done in another commit since that's easier for us Co-authored-by: Ennui Langeweile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ccfa82 - Browse repository at this point
Copy the full SHA 1ccfa82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 855a414 - Browse repository at this point
Copy the full SHA 855a414View commit details -
Improve the javadocs on DynamicRegistryFlag AGAIN
accidentally dropped a word guh
Configuration menu - View commit details
-
Copy full SHA for 9613027 - Browse repository at this point
Copy the full SHA 9613027View commit details -
Hopefully the final style change moment Co-authored-by: Ennui Langeweile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5789686 - Browse repository at this point
Copy the full SHA 5789686View commit details -
Implement style change in DynamicRegistryFlagManager
Co-authored-by: LambdAurora <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69f759b - Browse repository at this point
Copy the full SHA 69f759bView commit details -
Fix binary incompatibility hopefully?
- Added back methods to DynamicMetaRegistry with the same signature as the old ones to avoid binary incompatibility. These are marked as deprecated and should be removed in a breaking/major QSL release.
Configuration menu - View commit details
-
Copy full SHA for 55d23d2 - Browse repository at this point
Copy the full SHA 55d23d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f912a1c - Browse repository at this point
Copy the full SHA f912a1cView commit details -
Fix: Modify Tag path behavior in Dynamic Registries (QuiltMC#329)
* Implement tweak to Tags API to append `tags/` to the start of Dynamic Registries for tag creation that do not already have said path appended to the start of them already. This behavior also exits in FAPI as of the most recent release, and so adding it to QSL unifies the behavior of pure QSL and the upcoming QFAPI release in that regard. This can easily be moved to the Registry API to reduce intra-module requirements, but was put in the Tags API as that's the part of the game that is being modified here. * Move TagManagerLoaderMixin from Tags API to Registry API so that Tags API does not need to depend on Registry API for one very small mixin * Modify mixin injector name to be more descriptive and have `quilt$` prefix for debugging * Revert changes to quilt_tags.mixins.json * Added tests for tag namespace changes * go go gadget license generation --------- Co-authored-by: Ennui Langeweile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc6e2bb - Browse repository at this point
Copy the full SHA bc6e2bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 954897c - Browse repository at this point
Copy the full SHA 954897cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b82fc7 - Browse repository at this point
Copy the full SHA 1b82fc7View commit details -
Add stopguard on registering dynamic registries
No, you cannot use the `minecraft` namespace and blow up the world
Configuration menu - View commit details
-
Copy full SHA for 570d322 - Browse repository at this point
Copy the full SHA 570d322View commit details -
Configuration menu - View commit details
-
Copy full SHA for 696a299 - Browse repository at this point
Copy the full SHA 696a299View commit details -
Revert "Ran the licenser. Dear gods that's a lotta copyright year cha…
…nges wowie" This reverts commit 696a299.
Configuration menu - View commit details
-
Copy full SHA for 69c8361 - Browse repository at this point
Copy the full SHA 69c8361View commit details
Commits on Sep 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 662e6b0 - Browse repository at this point
Copy the full SHA 662e6b0View commit details