Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.4 feature backports #347

Merged
merged 20 commits into from
Oct 1, 2023

Commits on Sep 28, 2023

  1. Implement Dynamic Registry Flags.

    - Currently, only one flag, `OPTIONAL`, exists.
    - Modified DynamicRegistrySyncMixin in order to implement these flags. Due to the Redirect mixin header used to implement the flag filtering being taken directly from FAPI, the header of DynamicRegistrySyncMixin was changed to mention FabricMC copyright, in accordance with QSL contribution rules in CONTRIBUTING.md
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    64ce1e5 View commit details
    Browse the repository at this point in the history
  2. Implement Dynamic Registry Flags p2

    - Modify DynamicRegistryFlagManager to use Identifiers over RegistryKeys internally, in order to avoid generic-related jank.
    - Fix mixin ported from FAPI by correcting method target string to use Quilt Mappings.
    - Implement very basic tests.
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5d0d36a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4cb501 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cefd32a View commit details
    Browse the repository at this point in the history
  5. Implemented some changes suggested by Pyrofab

    - Added protected helper method DynamicMetaRegistryImpl#isFrozen for use in DynamicRegistryFlagManager
    - Added DynamicMetaRegistryImpl#LOGGER with the name "quilt_dynamic_registries" as a logger for catching exceptions related to the setting of flags
    - Removed the ability to disable dynamic registry flags, changed the signature of the related flag-enabling methods from enableFlag -> setFlag (on both DynamicRegistryFlag and DynamicRegistryFlagManager)
    - DynamicRegistryFlagManager#setFlag now throws an IllegalStateException if a mod attempts to enable a flag when dynamic registries are frozen. This is caught and printed to the logger mentioned prior in DynamicRegistryFlag calls
    - Added varargs for setting DynamicRegistryFlag values on dynamic registry creation
    - Improved DynamicRegistryFlag#OPTIONAL javadocs slightly
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    120c5cf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c8807ac View commit details
    Browse the repository at this point in the history
  7. Commit most style changes

    One of them needs a more specific wording change, so it's going to be done in another commit since that's easier for us
    
    Co-authored-by: Ennui Langeweile <[email protected]>
    cocona20xx and EnnuiL committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1ccfa82 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    855a414 View commit details
    Browse the repository at this point in the history
  9. Improve the javadocs on DynamicRegistryFlag AGAIN

    accidentally dropped a word
    
    guh
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9613027 View commit details
    Browse the repository at this point in the history
  10. BUT WAIT, THERE'S MORE!

    Hopefully the final style change moment
    
    Co-authored-by: Ennui Langeweile <[email protected]>
    cocona20xx and EnnuiL committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5789686 View commit details
    Browse the repository at this point in the history
  11. Implement style change in DynamicRegistryFlagManager

    Co-authored-by: LambdAurora <[email protected]>
    cocona20xx and LambdAurora committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    69f759b View commit details
    Browse the repository at this point in the history
  12. Fix binary incompatibility hopefully?

    - Added back methods to DynamicMetaRegistry with the same signature as the old ones to avoid binary incompatibility. These are marked as deprecated and should be removed in a breaking/major QSL release.
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    55d23d2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f912a1c View commit details
    Browse the repository at this point in the history
  14. Fix: Modify Tag path behavior in Dynamic Registries (QuiltMC#329)

    * Implement tweak to Tags API to append `tags/` to the start of Dynamic Registries for tag creation that do not already have said path appended to the start of them already.
    This behavior also exits in FAPI as of the most recent release, and so adding it to QSL unifies the behavior of pure QSL and the upcoming QFAPI release in that regard.
    This can easily be moved to the Registry API to reduce intra-module requirements, but was put in the Tags API as that's the part of the game that is being modified here.
    
    * Move TagManagerLoaderMixin from Tags API to Registry API so that Tags API does not need to depend on Registry API for one very small mixin
    
    * Modify mixin injector name to be more descriptive and have `quilt$` prefix for debugging
    
    * Revert changes to quilt_tags.mixins.json
    
    * Added tests for tag namespace changes
    
    * go go gadget license generation
    
    ---------
    
    Co-authored-by: Ennui Langeweile <[email protected]>
    cocona20xx and EnnuiL committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bc6e2bb View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    954897c View commit details
    Browse the repository at this point in the history
  16. Clean up the dynamic tag test

    EnnuiL authored and cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1b82fc7 View commit details
    Browse the repository at this point in the history
  17. Add stopguard on registering dynamic registries

    No, you cannot use the `minecraft` namespace and blow up the world
    EnnuiL authored and cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    570d322 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    696a299 View commit details
    Browse the repository at this point in the history
  19. Revert "Ran the licenser. Dear gods that's a lotta copyright year cha…

    …nges wowie"
    
    This reverts commit 696a299.
    cocona20xx committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    69c8361 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Configuration menu
    Copy the full SHA
    662e6b0 View commit details
    Browse the repository at this point in the history