Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managing multiple redirects in Qwik #6909

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Managing multiple redirects in Qwik #6909

merged 2 commits into from
Sep 24, 2024

Conversation

thejackshelton
Copy link
Member

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@thejackshelton thejackshelton requested a review from a team as a code owner September 24, 2024 12:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b7f58f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b7f58f2

@thejackshelton @ianlet
Update packages/docs/src/routes/docs/(qwikcity)/guides/redirects/inde…
b7f58f2 
…x.mdx


Completely agree. I also realized that mapping is due to historical reasons and to meet a specific app structure, so I think this is simpler.

Co-authored-by: Ian Létourneau <[email protected]>
gioboa
gioboa approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏nice use case
Thanks @thejackshelton

@thejackshelton thejackshelton merged commit 426ba59 into main Sep 24, 2024
16 checks passed
@thejackshelton thejackshelton deleted the thejackshelton-patch-2 branch September 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS approved these changes

@ianlet ianlet ianlet approved these changes

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thejackshelton @PatrickJS @ianlet @gioboa