Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC24 compat #114

Merged
merged 2 commits into from
May 3, 2022
Merged

NC24 compat #114

merged 2 commits into from
May 3, 2022

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Apr 28, 2022 •
edited
Loading

@R0Wi R0Wi force-pushed the feature/NC24 branch 7 times, most recently from 86f6e87 to f076cf7 Compare April 28, 2022 15:18
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #114 (1be1aee) into master (5aa118e) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #114   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       128       128           
===========================================
  Files             23        23           
  Lines            466       466           
  Branches           4         4           
===========================================
  Hits             466       466
Impacted Files Coverage Δ
lib/Model/WorkflowSettings.php 100.00% <ø> (ø)
lib/Wrapper/CommandWrapper.php 100.00% <ø> (ø)
lib/BackgroundJobs/ProcessFileJob.php 100.00% <100.00%> (ø)
lib/Service/GlobalSettingsService.php 100.00% <100.00%> (ø)
src/components/GlobalSettings.vue 100.00% <100.00%> (ø)
src/components/WorkflowOcr.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa118e...1be1aee. Read the comment docs.

@R0Wi R0Wi force-pushed the feature/NC24 branch 5 times, most recently from fa772f3 to bae1a51 Compare April 28, 2022 16:25
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@R0Wi R0Wi requested a review from bahnwaerter April 28, 2022 16:37
@R0Wi R0Wi marked this pull request as ready for review April 28, 2022 16:37
@R0Wi
Copy link
Contributor Author

R0Wi commented Apr 28, 2022

@bahnwaerter small check on fresh NC24 platform would be appreciated :-D

@R0Wi R0Wi merged commit 99c8218 into master May 3, 2022
@R0Wi R0Wi deleted the feature/NC24 branch May 3, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahnwaerter bahnwaerter Awaiting requested review from bahnwaerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@R0Wi