-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework mode select menu #624
Conversation
Marked as ready for review. Would also like to add keyboard navigation, but due to limited time that'll have to wait for next weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks so much for looking into it <3
Playing around with it real quick and this what I noted down:
- Marked For Death is teambased so it should probably be in PvP and not FFA.
- Right now categories are sorted alphabetically which is fine but it might make sense to sort them by popularity (not sure about that one though).
- The category filter doesn't seem to work for me. Switching through the categories it still displays all of them. Not sure what's going on there ^^"
<3
With mods adding their own gamemodes this is basically impossible. Sorting alphabetically also means some modes may get more exposure
Looks like i broke it |
Might also be worth removing the Custom category as it doesnt really fit in the PvP, PvE, ... sorting methodology |
Hmm, maybe. It would be kinda nice to have a distinction between Vanilla, Northstar, and 3rd party mod modes but I'm not sure how to combine that with sorting into PvP, PvE, etc categories without it turning out as a bunch of categories that have like 1-2 entries... ^^" |
Removed "READY TO MERGE" lable until merge conflicts are resolved |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed line-endings on main. This should be good to merge now ^^
Welp so somehow I missed that it kinda just marks all gamemodes as locked, fuck I really shouldn't test PRs while exhausted x_x |
TODO:
Docs:
Exposes
NSSetModeCategory( string mode, int category )
to allow mods / gamemodes to modify their category.Categories are difend in a global enum
eModeMenuModeCategory
Adds these vanilla files:
resource/ui/menus/mode_select.menu