Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant search for items in tilemap menu #1363

Closed
cosmiccoincidence opened this issue Nov 29, 2023 · 4 comments
Closed

Cant search for items in tilemap menu #1363

cosmiccoincidence opened this issue Nov 29, 2023 · 4 comments
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: Good first issue 🍰 Easy tasks Tilemaps Tasks related to the tilemap system or its connectors.

Comments

@cosmiccoincidence
Copy link
Member

cosmiccoincidence commented Nov 29, 2023

Current Behavior

When you try to search for many items by name in the tilemap menu, they are not properly registering via search.

In the video I first go to the items page (not necessary) to show there are 2 gloves. I then try to search for gloves and the moment I type "g" and only one glove shows up, I continue writing the word "glove" and it no longer shows up.

Unity_nxLuIZ8dYD.mp4

Steps to Reproduce

Open the tilemap menu using b and go to the items page and look for an item then trying searching for it in the search bar.

Solution

  • Remove case sensitivity for search.
  • Remove "namestring" field in scriptable objects and replace with object (file) name.
@cosmiccoincidence cosmiccoincidence added Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. Tilemaps Tasks related to the tilemap system or its connectors. Difficulty: medium 🥼 For those that already have some understanding of the code base. labels Nov 29, 2023
@cosmiccoincidence

This comment was marked as duplicate.

@cosmiccoincidence cosmiccoincidence added Difficulty: Good first issue 🍰 Easy tasks Bug: Confirmed Bugs that have been confirmed by another contributor. and removed Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. Difficulty: medium 🥼 For those that already have some understanding of the code base. labels Nov 29, 2023
@stilnat
Copy link
Contributor

stilnat commented Nov 29, 2023

search case is sensitive and is using the "name string" of the items scriptable objects. Please remove that field and replace it with simply getting the game object name to complete this issue.

image

@jckling
Copy link
Contributor

jckling commented Dec 6, 2023

nameString in ItemObjectSo is inherited from GenericObjectSo, should it be removed in GenericObjectSo?

If should, also need to change these to use object name

image

@stilnat
Copy link
Contributor

stilnat commented Dec 6, 2023

@jckling yes it should, thanks for pointing that out. Maybe keep name string but as a property, returning the prefab's name.

jckling pushed a commit to jckling/SS3D that referenced this issue Dec 7, 2023
cosmiccoincidence pushed a commit that referenced this issue Dec 7, 2023
* Change nameString to property; Fix search sensitive (#1363)

* Change name string to prefab name

---------

Co-authored-by: Shuqi.Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: Good first issue 🍰 Easy tasks Tilemaps Tasks related to the tilemap system or its connectors.
Projects
None yet
Development

No branches or pull requests

3 participants