Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directionnal adjacencies #1303

Merged
merged 97 commits into from
Nov 13, 2023

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Nov 10, 2023

Summary

This PR adds directionnals connectables, such as sofas, booths and bench.

link to updated doc : https://ss3d.gitbook.io/design/environment/connectables/directional-adjacency-connections

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

2023-10-30.21-26-26.mp4

Testing

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

Known issues

  • There's still a few rare edge cases I did not precisely identify but saw while testing randomly. In some complex configurations, removing directionnals or loading back can cause bad rotation and/or shapes. It's very rare though, and hard to identify in which configuration it occurs. I either need help to identify those, or we can merge and deal with them when they are better identified.

Related issues/PRs

@stilnat stilnat changed the title Directionnal adjacencies [WIP] Directionnal adjacencies Nov 10, 2023
@stilnat stilnat changed the title [WIP] Directionnal adjacencies Directionnal adjacencies Nov 10, 2023
@stilnat stilnat changed the title Directionnal adjacencies [WIP] Directionnal adjacencies Nov 10, 2023
@stilnat stilnat changed the title [WIP] Directionnal adjacencies Directionnal adjacencies Nov 10, 2023
@stilnat stilnat changed the title Directionnal adjacencies [WIP] Directionnal adjacencies Nov 10, 2023
@cosmiccoincidence cosmiccoincidence added the Tilemaps Tasks related to the tilemap system or its connectors. label Nov 10, 2023
@stilnat stilnat changed the title [WIP] Directionnal adjacencies Directionnal adjacencies Nov 11, 2023
@cosmiccoincidence

This comment was marked as off-topic.

@stilnat

This comment was marked as off-topic.

@cosmiccoincidence

This comment was marked as off-topic.

Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it worked great from what I've experienced. I'm happy with the performance, any problematic edge cases can be identified in the future. Please add and link documentation for this prior to merge.

namespace SS3D.Systems.Tile.Connections.AdjacencyTypes
{
[Serializable]
public struct DirectionnalShapeResolver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Directional" is spelt with a single n. Is the extra n in these script names intentional?

@@ -0,0 +1,142 @@
%YAML 1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add collision to this prefab
  • Remove cast shadows from this prefab

Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@cosmiccoincidence cosmiccoincidence merged commit 82481aa into RE-SS3D:develop Nov 13, 2023
2 checks passed
@stilnat stilnat deleted the Directionnal-adjacencies branch November 13, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tilemaps Tasks related to the tilemap system or its connectors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants