Improve console commands #1354
Merged
Improve console commands #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilnat
requested changes
Nov 23, 2023
There was a problem hiding this comment.
quick review :
hit body part seems to work okay, I tested it by cutting the right arm and then calling
hitbodypart HumanHandRightItem(Clone) all toxic 1000
it destroys it instantly as expected
same test for destroy body part, I get an exception
using command destroybodypart HumanHandRightItem(Clone)
NullReferenceException: Object reference not set to an instance of an object
SS3D.Systems.IngameConsoleSystem.Commands.Command.ReceiveCheckResponse[T] (System.String[] args, SS3D.Systems.IngameConsoleSystem.Commands.Command+CheckArgsResponse& response, T& calculatedValues) (at Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/Command.cs:67)
SS3D.Systems.IngameConsoleSystem.Commands.DestroyBodyPartCommand.Perform (System.String[] args, FishNet.Connection.NetworkConnection conn) (at Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/DestroyBodyPartCommand.cs:26)
SS3D.Systems.IngameConsoleSystem.CommandsController.RpcLogic___CmdProcessOnlineCommand_161581254 (System.String commandName, System.String[] args, FishNet.Connection.NetworkConnection conn) (at Assets/Scripts/SS3D/Systems/IngameConsoleSystem/CommandsController.cs:127)
stilnat
requested changes
Nov 30, 2023
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/HurtCommand.cs
Outdated
Show resolved
Hide resolved
stilnat
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a couple of methods to remove code repetition and significantly shorten all the commands.
Also fix a little bug, where long help command was executing twice