Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove audio from lobby #1389

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Dec 10, 2023

Summary

Make ambient sounds only play when onboarding.

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

Testing

Networking checklist

  • Works from host in host mode.
  • Works from server in server mode.
  • Works on server in client mode.
  • Works and is syncronized across different clients.
  • Is persistent.

Changes

Just added an event in the entity system. When a player spawn, a target rpc is sent to the client spawning, and the onSpawned event is called. The ambiant system suscribes to that.

Related issues/PRs

closes #1352

@joaoburatto joaoburatto merged commit f604811 into RE-SS3D:develop Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambient sounds are playing in lobby
2 participants