Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing filters to slot inventories #1425

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

David-Goru
Copy link
Contributor

Summary

This PR adds the "Belt" filter and trait and sets up the "Belt" and "IDSlot" filters

I'm not sure if it is expected to add any possible trait/filter that will be used (like for the HeadContainer, which is not in use as far as I can see, but may be in the future). If so, please let me know which containers we'll need to have the filters/traits and I'll gladly set them up!

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.
  • Update the related GitBook document, or create a new one if needed.

Pictures/Videos)

Belt.and.IDSlot.filters.working.mp4

Testing

Try to drag any item to the BeltContainer - only the Toolbelt should work
Try to drag any item to the ID container - only PDAs/IDs should work

Changes

"Belt" filter has been added to the "BeltContainer" inventory slot (in the Human prefab), and the "Belt" trait has been added to the "Toolbelt" as an starting trait

Also, "IDSlot" filter was already created and the "IDSlot" trait was already in the PDAs/IDs, but the "ID container" inventory slot didn't have the filter attached - so this PR fixes it

Related issues/PRs

Closes #1364

Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work ! we're good with id and toolbelt for now, but we'll probably have more containers to set up in the future, just need to write it down.

@stilnat stilnat merged commit 8beb708 into RE-SS3D:develop Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot inventories should only contain certain things
2 participants