Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #119

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Dev #119

merged 3 commits into from
Sep 7, 2022

Conversation

juyeongkim
Copy link
Member

Description

Related Issue

Example

Checklist for Reviewer

This Pull Request should follow ImmuneSpaceR Package Development Guide

  • Can you build it yourself and test the new features or changes?
  • Is it functional, and does it meet the requirements?
  • Is it readable?
    • Easy to understand
  • Is it following the functional coding guide?
  • Is it following the style guide (No changes in styler::style_pkg())?
  • Is it well documented (clear and sufficient)?
    • Comments make sense
    • Updated or new vignette or manual
  • Does it have new/updated unit tests?
    • Use the covr package to examine the extent of test coverage
  • Does it have new dependencies? Is it justifiable?
  • Is there code duplication that should be reduced?
  • Are there user interface improvements that could be made?
  • Are there performance improvements that could be made?
  • Is it passing R CMD check?
  • Is it passing BiocCheck::BiocCheck()?

@juyeongkim juyeongkim merged commit 7a9f0da into main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juyeongkim