Skip to content

Commit

Permalink
tests: provide test for vfs+fmt corner-case
Browse files Browse the repository at this point in the history
On `native` when using `vfs` the `fmt` print functions do not work.
This is because the `fmt` module uses the `write()` system call which
is bend by the `native_vfs` module to use `vfs_write()`. However,
`native` does not use a `stdio` module to print. Instead, it just
writes to the hosts standard I/O directly. As such, STDIN, STDOUT, and
STDERR are never initialized for `vfs` so `vfs` does not recognize
`STDIN_FILENO`, `STDOUT_FILENO` and `STDERR_FILENO` as valid file
descriptors.

This test case showcases this bug.
  • Loading branch information
miri64 committed Dec 18, 2019
1 parent 33b1f9e commit 1b125b7
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tests/vfs_plus_stdio/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
DEVELHELP=0
include ../Makefile.tests_common

USEMODULE += vfs
USEMODULE += fmt

include $(RIOTBASE)/Makefile.include
27 changes: 27 additions & 0 deletions tests/vfs_plus_stdio/main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
* Copyright (C) 2019 Freie Universität Berlin
*
* This file is subject to the terms and conditions of the GNU Lesser
* General Public License v2.1. See the file LICENSE in the top level
* directory for more details.
*/

/**
* @ingroup tests
* @{
*
* @file
* @brief Tests VFS together with stdio on a board
*
* @author Martine S. Lenders <[email protected]>
*
* @}
*/

#include "fmt.h"

int main(void)
{
print_str("SUCCESS\n");
return 0;
}
18 changes: 18 additions & 0 deletions tests/vfs_plus_stdio/tests/01-run.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env python3

# Copyright (C) 2019 Freie Universität Berlin
#
# This file is subject to the terms and conditions of the GNU Lesser
# General Public License v2.1. See the file LICENSE in the top level
# directory for more details.

import sys
from testrunner import run


def testfunc(child):
child.expect(r'SUCCESS')


if __name__ == "__main__":
sys.exit(run(testfunc))

0 comments on commit 1b125b7

Please sign in to comment.