Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_tftp: add deprecation note #11778

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 3, 2019

Contribution description

gnrc_tftp got into a quite unmaintainable state and has many quality defects (the port of the server changes randomly on connect from a client, it does reliably not work with multiple interfaces, ...). As such I'm voting to deprecate it. With CoAP we have a way more stable alternative.

Testing procedure

tftp should appear in doc/doxygen/html/deprecated.html after make doc

Issues/PRs references

Related to #11773, but not dependent on it.

@miri64 miri64 added Area: network Area: Networking Area: doc Area: Documentation Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jul 3, 2019
@miri64 miri64 added this to the Release 2019.07 milestone Jul 3, 2019
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 3, 2019
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better please squash.

@MrKevinWeiss MrKevinWeiss added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jul 3, 2019
@miri64
Copy link
Member Author

miri64 commented Jul 3, 2019

Squashed.

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@MrKevinWeiss MrKevinWeiss merged commit cd6544e into RIOT-OS:master Jul 3, 2019
@miri64 miri64 deleted the gnrc_tftp/doc/deprecate branch July 3, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants