Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdev: remove NETOPT_IPV6_IID support for network devices #14354

Merged
merged 8 commits into from
Jun 25, 2020
Merged

netdev: remove NETOPT_IPV6_IID support for network devices #14354

merged 8 commits into from
Jun 25, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jun 25, 2020 •
edited by aabadie
Loading

Contribution description

This option is handled in the gnrc_netif-layer without any access to the driver's option since #10569.

The implementation on the device driver is deprecated and was slated for removal in 2019.07 already, so let's get rid of them.

Testing procedure

Auto-generated IPv6 addresses do not change compared to master in examples/gnrc_networking on

  • Ethernet-based boards (e.g. native)
  • IEEE-802.15.4-based boards including xbee. (e.g. samr21-xpro and arduino-due + xbee)
  • nrfmin-based boards (e.g. nrf51dk)
  • cc110x-based boards (e.g. msba2)

Same for tests/nordic_softdevice.

Tests still pass.

Issues/PRs references

Very late follow-up on #10569 and #10595

@miri64
nrfmin: remove NETOPT_IPV6_IID support
78fc1e7 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64 miri64 added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jun 25, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jun 25, 2020
@fjmolinas
Copy link
Contributor

xbee + arduino-zero

  • pr
2020-06-25 11:32:22,656 # ifconfig
2020-06-25 11:32:22,700 # Iface  7  HWaddr: D4:44  Channel: 26  NID: 0x23 
2020-06-25 11:32:22,705 #           Long HWaddr: 00:13:A2:00:40:C2:D4:C4 
2020-06-25 11:32:22,709 #           L2-PDU:100 MTU:1280  HL:64  RTR  
2020-06-25 11:32:22,711 #           6LO  IPHC  
2020-06-25 11:32:22,714 #           Source address length: 8
2020-06-25 11:32:22,717 #           Link type: wireless
2020-06-25 11:32:22,723 #           inet6 addr: fe80::213:a200:40c2:d4c4  scope: link  VAL
2020-06-25 11:32:22,726 #           inet6 group: ff02::2
2020-06-25 11:32:22,729 #           inet6 group: ff02::1
2020-06-25 11:32:22,732 #           inet6 group: ff02::1:ffc2:d4c4
2020-06-25 11:32:22,733 #           
2020-06-25 11:32:22,736 #           Statistics for Layer 2
2020-06-25 11:32:22,739 #             RX packets 0  bytes 0
2020-06-25 11:32:22,744 #             TX packets 0 (Multicast: 0)  bytes 72
2020-06-25 11:32:22,747 #             TX succeeded 0 errors 0
2020-06-25 11:32:22,750 #           Statistics for IPv6
2020-06-25 11:32:22,753 #             RX packets 0  bytes 0
2020-06-25 11:32:22,757 #             TX packets 2 (Multicast: 2)  bytes 128
2020-06-25 11:32:22,760 #             TX succeeded 2 errors 0
2020-06-25 11:32:22,761 #
  • master
2020-06-25 11:31:28,191 #  ifconfig
2020-06-25 11:31:28,236 # Iface  7  HWaddr: D4:44  Channel: 26  NID: 0x23 
2020-06-25 11:31:28,240 #           Long HWaddr: 00:13:A2:00:40:C2:D4:C4 
2020-06-25 11:31:28,244 #           L2-PDU:100 MTU:1280  HL:64  RTR  
2020-06-25 11:31:28,247 #           6LO  IPHC  
2020-06-25 11:31:28,250 #           Source address length: 8
2020-06-25 11:31:28,252 #           Link type: wireless
2020-06-25 11:31:28,258 #           inet6 addr: fe80::213:a200:40c2:d4c4  scope: link  VAL
2020-06-25 11:31:28,261 #           inet6 group: ff02::2
2020-06-25 11:31:28,264 #           inet6 group: ff02::1
2020-06-25 11:31:28,268 #           inet6 group: ff02::1:ffc2:d4c4
2020-06-25 11:31:28,269 #           
2020-06-25 11:31:28,272 #           Statistics for Layer 2
2020-06-25 11:31:28,275 #             RX packets 0  bytes 0
2020-06-25 11:31:28,279 #             TX packets 0 (Multicast: 0)  bytes 144
2020-06-25 11:31:28,282 #             TX succeeded 0 errors 0
2020-06-25 11:31:28,285 #           Statistics for IPv6
2020-06-25 11:31:28,288 #             RX packets 0  bytes 0
2020-06-25 11:31:28,293 #             TX packets 4 (Multicast: 4)  bytes 256
2020-06-25 11:31:28,296 #             TX succeeded 4 errors 0
2020-06-25 11:31:28,296 #

@fjmolinas
Copy link
Contributor

native

  • pr
ifconfig
Iface  6  HWaddr: 52:28:3F:CA:BB:2B 
          L2-PDU:1500 MTU:1500  HL:64  RTR  
          RTR_ADV  
          Source address length: 6
          Link type: wired
          inet6 addr: fe80::5028:3fff:feca:bb2b  scope: link  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffca:bb2b
          
          Statistics for Layer 2
            RX packets 19  bytes 3296
            TX packets 1 (Multicast: 1)  bytes 78
            TX succeeded 1 errors 0
          Statistics for IPv6
            RX packets 19  bytes 3030
            TX packets 1 (Multicast: 1)  bytes 64
            TX succeeded 1 errors 0
  • master
Iface  6  HWaddr: 52:28:3F:CA:BB:2B 
          L2-PDU:1500 MTU:1500  HL:64  RTR  
          RTR_ADV  
          Source address length: 6
          Link type: wired
          inet6 addr: fe80::5028:3fff:feca:bb2b  scope: link  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffca:bb2b
          
          Statistics for Layer 2
            RX packets 5  bytes 843
            TX packets 1 (Multicast: 1)  bytes 78
            TX succeeded 1 errors 0
          Statistics for IPv6
            RX packets 5  bytes 773
            TX packets 1 (Multicast: 1)  bytes 64
            TX succeeded 1 errors 0

@aabadie
Copy link
Contributor

aabadie commented Jun 25, 2020

Tested on nrf51dk:

this PR 
> ifconfig
ifconfig
Iface  7  HWaddr: 45:8B  Channel: 0  NID: 0xaffe 
           TX-Power: 0dBm  State: IDLE 
          L2-PDU:200 MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Link type: wireless
          inet6 addr: fe80::ff:fe00:458b  scope: link  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff00:458b
          
          Statistics for Layer 2
            RX packets 0  bytes 0
            TX packets 0 (Multicast: 0)  bytes 52
            TX succeeded 0 errors 0
          Statistics for IPv6
            RX packets 0  bytes 0
            TX packets 2 (Multicast: 2)  bytes 112
            TX succeeded 2 errors 0
master 
> ifconfig
ifconfig
Iface  7  HWaddr: 45:8B  Channel: 0  NID: 0xaffe 
           TX-Power: 0dBm  State: IDLE 
          L2-PDU:200 MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Link type: wireless
          inet6 addr: fe80::ff:fe00:458b  scope: link  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff00:458b
          
          Statistics for Layer 2
            RX packets 0  bytes 0
            TX packets 0 (Multicast: 0)  bytes 52
            TX succeeded 0 errors 0
          Statistics for IPv6
            RX packets 0  bytes 0
            TX packets 2 (Multicast: 2)  bytes 112
            TX succeeded 2 errors 0

>

@fjmolinas
Copy link
Contributor

@maribu @kaspar030 do you have an msba2?

@fjmolinas fjmolinas added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 25, 2020
@miri64
Copy link
Member Author

miri64 commented Jun 25, 2020

@fjmolinas @aabadie remember also to test tests/nordic_softdevice with an eligeble device.

@miri64
Copy link
Member Author

miri64 commented Jun 25, 2020

Fixed issues pointed out by Murdock

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jun 25, 2020
@miri64
cc110x: remove NETOPT_IPV6_IID support
4c01c71 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64
netdev_eth: remove NETOPT_IPV6_IID support
3a60a78 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64
netdev_ieee802154: remove NETOPT_IPV6_IID support
7777c17 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64
xbee: remove NETOPT_IPV6_IID support
14afbe1 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64
pkg/nordic_softdevice_ble: remove NETOPT_IPV6_IID support
0035bf0 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64
tests/gnrc_ipv6_nib_6ln: remove NETOPT_IPV6_IID support in mock-device
1399f6f 
This option is handled in the `gnrc_netif`-layer without any access to
the driver's option since 7ae9056.
@miri64 miri64 force-pushed the drivers/cleanup/rm-NETOPT_IPV6_IID branch from ca0ce47 to de74765 Compare June 25, 2020 11:42
@miri64
Copy link
Member Author

miri64 commented Jun 25, 2020

Just noticed that I accidentally had put the xbee change into another commit, so I had to reorganize my git history. As such I squashed.

@aabadie
Copy link
Contributor

aabadie commented Jun 25, 2020

remember also to test tests/nordic_softdevice with an eligeble device.

nordic softdevice is not working for me. I tried on nrf52832-mdk with this PR, master, 2020.04, 2020.01. I'm wondering if it ever worked on this board (I'm flashing with openocd, jlink is not available).
BTW, is nordic softdevice so important since it's deprecated ?

@miri64
Copy link
Member Author

miri64 commented Jun 25, 2020

BTW, is nordic softdevice so important since it's deprecated ?

Nope. We can skip if it, if need be. Same (even though not deprecated) for cc110x: I think the tests already done, show already, that this option is not needed anymore.

@miri64 miri64 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 25, 2020
@fjmolinas
Copy link
Contributor

Nope. We can skip if it, if need be. Same (even though not deprecated) for cc110x: I think the tests already done, show already, that this option is not needed anymore.

I think its ok to proceed here.

fjmolinas
fjmolinas approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fjmolinas fjmolinas merged commit 903ad1e into RIOT-OS:master Jun 25, 2020
@miri64 miri64 deleted the drivers/cleanup/rm-NETOPT_IPV6_IID branch June 25, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@maribu maribu Awaiting requested review from maribu maribu is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @fjmolinas @aabadie