Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/emb6: remove deprecated package #14494

Merged
merged 2 commits into from
Jul 11, 2020
Merged

pkg/emb6: remove deprecated package #14494

merged 2 commits into from
Jul 11, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 10, 2020

Contribution description

Deprecation was noted in #12389 and its after 2020.07 feature freeze now.

Testing procedure

There should be no mention of emb6 now in the tree, except for LOSTANDFOUND.md and the release notes.

Issues/PRs references

Follow-up on #12389

@miri64 miri64 added Area: network Area: Networking Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jul 10, 2020
@miri64 miri64 added this to the Release 2020.10 milestone Jul 10, 2020
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 10, 2020
benpicco
benpicco approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No trace of emb6 can be found in this branch, package has been deprecated.

@miri64
Copy link
Member Author

miri64 commented Jul 11, 2020

Rebased to account for merge conflict by merging #14491 and #14495 in the meantime:

git range-diff upstream/master 66e89fb ac3a22f
1:  a72aa0a98d ! 1:  4f243c52ea pkg/emb6: remove deprecated package
    @@ tests/emb6/Makefile.ci (deleted)
     -    stm32l0538-disco \
     -    telosb \
     -    waspmote-pro \
    --    wsn430-v1_3b \
    --    wsn430-v1_4 \
     -    z1 \
     -    #
     
2:  66e89fb4be < -:  ---------- LOSTANDFOUND.md: document removal of emb6
-:  ---------- > 2:  ac3a22f548 LOSTANDFOUND.md: document removal of emb6

@miri64 miri64 merged commit 651b506 into RIOT-OS:master Jul 11, 2020
@miri64 miri64 deleted the emb6/cleanup/rm branch July 11, 2020 00:49
miri64 added a commit to RIOT-OS/Release-Specs that referenced this pull request Jul 11, 2020
@miri64
08-interop: deprecate 9-10
e90e304 
`emb6` was deprecated in [1] and removed in [2] so it does not make
much sense to test this anymore, even for 2020.07.

[1] RIOT-OS/RIOT#12389
[2] RIOT-OS/RIOT#14494
@miri64 miri64 mentioned this pull request Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@OlegHahm OlegHahm Awaiting requested review from OlegHahm

@emmanuelsearch emmanuelsearch Awaiting requested review from emmanuelsearch

Assignees
No one assigned
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @benpicco