Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/gcoap: remove gcoap_finish #14550

Merged
merged 1 commit into from
Jul 22, 2020
Merged

net/gcoap: remove gcoap_finish #14550

merged 1 commit into from
Jul 22, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

gcoap_finish has been deprecated and scheduled for removal in #12838. #14542 removed the remaining usages of it. This PR removes the function and its related macros.

Testing procedure

  • tests/unittests/tests-gcoap should be working
  • examples/gcoap should be used to test the CoAP functionalities

I tested this by running the release spec tests using RIOT-OS/Release-Specs#168 (see output here), and checking the messages on WireShark, maybe it would be good to have some further testing.

Issues/PRs references

Deprecated in #12838

@leandrolanzieri leandrolanzieri added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: CoAP Area: Constrained Application Protocol implementations labels Jul 17, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 17, 2020
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 17, 2020
cgundogan
cgundogan approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Tested with two native instances (gcoap example) and did a couple of CoAP get/put operations. Wireshark also didn't complain about invalid packets. ACK.

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 22, 2020
@cgundogan cgundogan merged commit a0c4b8a into RIOT-OS:master Jul 22, 2020
@leandrolanzieri leandrolanzieri deleted the pr/net/gcoap_remove_gcoap_finish branch July 22, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@kb2ma kb2ma Awaiting requested review from kb2ma

@pokgak pokgak Awaiting requested review from pokgak

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @cgundogan @bergzand