Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/posix/socket: fix wrong member access #16849

Merged
merged 2 commits into from
Sep 14, 2021
Merged

sys/posix/socket: fix wrong member access #16849

merged 2 commits into from
Sep 14, 2021

Conversation

HendrikVE
Copy link
Contributor

Contribution description

Since #12975 was merged the module posix_sockets cannot be compiled when sock_ip or sock_tcp is used.

Testing procedure

You can test this PR e.g. in conjunction with everything else in #15969.

Issues/PRs references

This PR is split out from the chunky #15969.

@github-actions github-actions bot added the Area: sys Area: System label Sep 14, 2021
@HendrikVE HendrikVE added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Sep 14, 2021
@HendrikVE HendrikVE mentioned this pull request Sep 14, 2021
Open
8 tasks
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Sep 14, 2021
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 14, 2021
@benpicco
Copy link
Contributor

I think it's a problem that there is no test case to exercise this code path on CI.
But I guess #15969 will fix this.

@benpicco benpicco merged commit bfe64fe into RIOT-OS:master Sep 14, 2021
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
@HendrikVE HendrikVE deleted the pr/wolfmqtt_split_1 branch January 6, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.
3 participants
@HendrikVE @benpicco @miri64