Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero width space in Telegram usernames sent to IRC (closes #113). #128

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Add zero width space in Telegram usernames sent to IRC (closes #113). #128

merged 1 commit into from
Mar 3, 2019

Conversation

Tjzabel
Copy link
Member

@Tjzabel Tjzabel commented Mar 3, 2019

This PR solves the problem of a user accidentally pinging himself on IRC when the user's Telegram and IRC nicks are the same.

@Tjzabel Tjzabel added priority:high quality assurance CI tests, unit tests, integration tests, any kind of testing new change Adds new capabilities or functionality labels Mar 3, 2019
@Tjzabel Tjzabel added this to the v1.3 milestone Mar 3, 2019
@Tjzabel Tjzabel requested a review from a team March 3, 2019 18:31
jwflory
jwflory approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome to me. Makes perfect sense and also doesn't require any user configuration. 🎉

I'm going to merge this and work on getting v1.3 out the door. 🎬

@jwflory jwflory merged commit 1207f99 into master Mar 3, 2019
@jwflory jwflory deleted the add/zero-width-space branch March 3, 2019 23:37
@jwflory jwflory mentioned this pull request Mar 3, 2019
Closed
@Tjzabel Tjzabel restored the add/zero-width-space branch July 20, 2019 18:45
@Tjzabel Tjzabel deleted the add/zero-width-space branch July 20, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwflory jwflory jwflory approved these changes

Assignees

@thenaterhood thenaterhood

@jwflory jwflory

@Tjzabel Tjzabel

Labels
new change Adds new capabilities or functionality quality assurance CI tests, unit tests, integration tests, any kind of testing
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Tjzabel @jwflory @thenaterhood