Fix long lines being cut by the IRC server #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user890104
force-pushed
the
bugfix/long-lines
branch
from
51d96af
to
1d74711
Compare
|
Hello, can you please add a unit test for if a long message goes over the max length? |
|
It actually looks like we may be able to get native support from lrstanley/girc#43. Going to keep this PR open until I can look into this further. |
jwflory
force-pushed
the
bugfix/long-lines
branch
from
158dc06
to
7987774
Compare
jwflory
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split long messages to runes, according to IRC server's max line length