Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links and resolve inconsistencies #264

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix broken links and resolve inconsistencies #264

merged 3 commits into from
May 3, 2024

Conversation

peterjunpark
Copy link
Contributor

In this PR:

Change absolute links to relative for maintainability.
Fix inconsistencies to adhere to Google style guide.
Fix rST warnings.

@peterjunpark
Fix broken links and resolve inconsistencies
467be5e 
Change absolute links to relative for maintainability.
Fix inconsistencies to adhere to Google style guide.
@peterjunpark peterjunpark added documentation Improvements or additions to documentation noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. ci:docs-only Only run Read the Docs CI on this PR labels Apr 19, 2024
@peterjunpark peterjunpark marked this pull request as ready for review April 19, 2024 18:44
@cgmb cgmb removed the noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. label Apr 19, 2024
@peterjunpark
Copy link
Contributor Author

@ROCm/rocm-documentation Can you review please?

yhuiYH
yhuiYH approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@yhuiYH yhuiYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I fixed 1 old link for you.

@cgmb cgmb merged commit ffe58f5 into ROCm:develop May 3, 2024
7 of 11 checks passed
@peterjunpark peterjunpark mentioned this pull request May 8, 2024
Draft
samjwu added a commit that referenced this pull request Jul 4, 2024
@randyh62 @samjwu
@dependabot @peterjunpark @yhuiYH
Cherry pick docs for 6.2 (#298)
4e095b9 
* Update precheckin CI configuration (#233)

Update precheckin ci config

* Bump rocm-docs-core from 1.0.0 to 1.1.0 in /docs/sphinx (#268)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.0.0...v1.1.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rocm-docs-core from 1.1.0 to 1.1.1 in /docs/sphinx (#269)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix broken links and resolve inconsistencies (#264)

* Fix broken links and resolve inconsistencies

Change absolute links to relative for maintainability.
Fix inconsistencies to adhere to Google style guide.

* Fix rst formatting and style

* Use updated ROCm org link path

---------

Co-authored-by: Young Hui - AMD <[email protected]>

* Bump rocm-docs-core from 1.1.1 to 1.1.3 in /docs/sphinx (#279)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 1.1.1 to 1.1.3.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.1.1...v1.1.3)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rocm-docs-core from 1.1.3 to 1.2.0 in /docs/sphinx (#280)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 1.1.3 to 1.2.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.1.3...v1.2.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rocm-docs-core from 1.2.0 to 1.3.0 in /docs/sphinx (#282)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump rocm-docs-core from 1.3.0 to 1.4.0 in /docs/sphinx (#284)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.3.0...v1.4.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix links in README and docs (#273)

* update menu and fix link (#290)

* Bump rocm-docs-core from 1.4.0 to 1.4.1 in /docs/sphinx (#296)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sam Wu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: peter <[email protected]>
Co-authored-by: Young Hui - AMD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmb cgmb cgmb approved these changes

@yhuiYH yhuiYH yhuiYH approved these changes

@jzuniga-amd jzuniga-amd Awaiting requested review from jzuniga-amd jzuniga-amd is a code owner

@tfalders tfalders Awaiting requested review from tfalders tfalders is a code owner

@qjojo qjojo Awaiting requested review from qjojo qjojo is a code owner

@EdDAzevedo EdDAzevedo Awaiting requested review from EdDAzevedo EdDAzevedo is a code owner

@jmachado-amd jmachado-amd Awaiting requested review from jmachado-amd jmachado-amd is a code owner

Assignees
No one assigned
Labels
ci:docs-only Only run Read the Docs CI on this PR documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterjunpark @cgmb @yhuiYH