Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing perfetto counter track names #20

Closed
jrmadsen opened this issue Jun 6, 2022 · 0 comments · Fixed by #28
Closed

Missing perfetto counter track names #20

jrmadsen opened this issue Jun 6, 2022 · 0 comments · Fixed by #28
Labels
bug Something isn't working libomnitrace Involves omnitrace library perfetto Issue affects/involves perfetto features/capabilities process sampling Background system-level sampling performed in background thread

Comments

@jrmadsen
Copy link
Collaborator

jrmadsen commented Jun 6, 2022

perfetto_counter_track needs to use:

    using name_map_t  = std::map<uint32_t, std::vector<std::unique_ptr<std::string>>>;

instead of

    using name_map_t  = std::map<uint32_t, std::vector<std::string>>;

because the underlying C-string passed to perfetto::CounterTrack (i.e. perfetto::CounterTrack{ _name.c_str() }) is occasionally invalidated when the vector is reallocated. This typically shows up in the rocm-smi GPU samples

@jrmadsen jrmadsen added bug Something isn't working perfetto Issue affects/involves perfetto features/capabilities libomnitrace Involves omnitrace library process sampling Background system-level sampling performed in background thread labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libomnitrace Involves omnitrace library perfetto Issue affects/involves perfetto features/capabilities process sampling Background system-level sampling performed in background thread
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant