Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perfetto_counter_track string lifetime #28

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Fix perfetto_counter_track string lifetime #28

merged 2 commits into from
Jun 7, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Jun 7, 2022

  • ensure the C-string pointer backing the perfetto::CounterTrack label is not still valid even after resizing container

Closes #20

@jrmadsen
Fix perfetto_counter_track string lifetime
5489381 
- ensure the C-string pointer backing the perfetto::CounterTrack label is not still valid even after resizing container
@jrmadsen
STL includes
f2f9e98
@jrmadsen jrmadsen added bug fix Fixes a bug perfetto Issue affects/involves perfetto features/capabilities sampling Statistical sampling via interrupts process sampling Background system-level sampling performed in background thread rocm-smi ROCm System Management Interface testing Extends/improves/modifies testing labels Jun 7, 2022
@jrmadsen jrmadsen merged commit 3031f17 into ROCm:main Jun 7, 2022
@jrmadsen jrmadsen deleted the fix-perfetto-counter-track-string-lifetime branch June 7, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug perfetto Issue affects/involves perfetto features/capabilities process sampling Background system-level sampling performed in background thread rocm-smi ROCm System Management Interface sampling Statistical sampling via interrupts testing Extends/improves/modifies testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing perfetto counter track names
1 participant
@jrmadsen