Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm environment fixes + workflow updates #117

Merged
merged 11 commits into from
Jul 27, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • ROCm 5.2 moved the ROCP_METRICS file to ${ROCM_PATH}/lib/rocprofiler/metrics.xml
    • ROCm 5.1 and older had the ROCP_METRICS file in ${ROCM_PATH}/rocprofiler/lib/metrics.xml
    • i.e. rocprofiler/lib --> lib/rocprofiler
  • Added some if: conditions to workflows to avoid them running on forks
  • Added support for auto-generating release draft when tags are pushed
  • Added support for auto-uploading CPack installers when tags are pushed
  • Fixed stripping of "OnLoadToolProp" and "OnUnloadTool" when stripping option is enabled
  • Improved locating the ROCm libraries which need to dlopened
  • Bumped version to 1.3.1

@jrmadsen jrmadsen added bug fix Fixes a bug libomnitrace Involves omnitrace library roctracer GPU kernel tracing testing Extends/improves/modifies testing cmake Modifies the CMake build system cpack Modifies the CPack packaging system rocprofiler GPU kernel HW counters labels Jul 27, 2022
@jrmadsen jrmadsen merged commit 7e31d9f into ROCm:main Jul 27, 2022
@jrmadsen jrmadsen deleted the rocm-dlopen-fixes branch July 27, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug cmake Modifies the CMake build system cpack Modifies the CPack packaging system libomnitrace Involves omnitrace library rocprofiler GPU kernel HW counters roctracer GPU kernel tracing testing Extends/improves/modifies testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant