Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building w/ hip, etc. but w/o rocprofiler #159

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix building w/ hip, etc. but w/o rocprofiler #159

merged 1 commit into from
Sep 14, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • Fixes builds with OMNITRACE_USE_ROCPROFILER=OFF but OMNITRACE_USE_ROCTRACER=ON
  • Move rocprofiler/hsa_rsrc_factory.{hpp,cpp}` to rocm folder

@jrmadsen jrmadsen added bug fix Fixes a bug roctracer GPU kernel tracing cmake Modifies the CMake build system rocprofiler GPU kernel HW counters labels Sep 14, 2022
@jrmadsen jrmadsen merged commit 472e96a into ROCm:main Sep 14, 2022
@jrmadsen jrmadsen deleted the fix-building-without-rocprofiler branch September 14, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug cmake Modifies the CMake build system rocprofiler GPU kernel HW counters roctracer GPU kernel tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen