Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crusher hackathon updates #164

Merged
merged 10 commits into from
Sep 21, 2022
Merged

Crusher hackathon updates #164

merged 10 commits into from
Sep 21, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Sep 20, 2022 •
edited
Loading

  • improved error handling in dyninst
  • improved error handling in omnitrace exe
  • new logging facility for omnitrace exe
  • improved backtraces
  • disable concurrent kernels in rocprofiler
  • updates setup-env.sh and modulefile
  • No longer make setting HSA_ENABLE_INTERRUPT=0 the default
    • this has performance implications
    • this was set to workaround a bug in ROCR which caused an ioctl call in ROCm to hang when interrupted. But it was only interrupted when realtime sampling was enabled since the CPU-clock doesn't increment when waiting
    • This bug should be fixed in ROCm 5.3
    • omnitrace no longer activates a realtime sampler by default when sampling, thus this bug is no longer encountered unless the user explicitly triggers realtime sampling

@jrmadsen
signal handler in omnitrace exe
3f4c27e
@jrmadsen
user library updates
1f0fec0 
- split user.h into header with types and header with functions
@jrmadsen
rename thread_info fields
76313a8 
- LookupTID -> InternalTID
- InternalTID -> SequentTID
- lookup_value -> internal_value
- internal_value -> sequent_value
- construct_on_thread w/ instead instead of thread-local construct_on_init for thread_data
@jrmadsen
Update dyninst submodule with error handling changes
024cf99
@jrmadsen
Update timemory submodule with numerous changes
04aeb36 
- mostly maintenance + some improvements for sampling
@jrmadsen
Disable rocprofiler concurrent kernels mode
39e3881
@jrmadsen
omnitrace instrumentation logging facilities
2517eae
@jrmadsen jrmadsen added bug fix Fixes a bug timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library libomnitrace-user Involves omnitrace-user library omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) binary instrumentation Binary instrumentation testing Extends/improves/modifies testing cmake Modifies the CMake build system submodule Updates a git submodule Dyninst Involves Dyninst rocprofiler GPU kernel HW counters labels Sep 20, 2022
@jrmadsen
timemory submodule update
5caf70e 
- fix compile error with gcc-7
- fix operation::generic_deleter calling reset on components
@jrmadsen
Update setup-env.sh and modulefile
069be14 
- set omnitrace_ROOT
- set HSA_TOOLS_LIB + ROCP_TOOL_LIB, etc.
@jrmadsen
Remove setting HSA_ENABLE_INTERRUPT=0
af5ffa2 
- Remove setting HSA_TOOLS_LIB in binary instrument (redundant)
@jrmadsen jrmadsen merged commit 90ff718 into ROCm:main Sep 21, 2022
@jrmadsen jrmadsen deleted the crusher-hackathon-updates branch September 21, 2022 18:58
@jrmadsen jrmadsen mentioned this pull request Sep 21, 2022
Closed
@jrmadsen jrmadsen mentioned this pull request Oct 1, 2022
Closed
@jrmadsen jrmadsen mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
binary instrumentation Binary instrumentation bug fix Fixes a bug cmake Modifies the CMake build system Dyninst Involves Dyninst libomnitrace Involves omnitrace library libomnitrace-user Involves omnitrace-user library omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) rocprofiler GPU kernel HW counters submodule Updates a git submodule testing Extends/improves/modifies testing timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module file: no environment variable with absolute install path
1 participant
@jrmadsen