Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise default min number of instructions #173

Merged
merged 3 commits into from
Oct 1, 2022
Merged

Raise default min number of instructions #173

merged 3 commits into from
Oct 1, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Sep 30, 2022 •
edited
Loading

  • Raise min instructions default to 1024 instead of 64
    • Default value of 64 has demonstrated tendency to slow down real-life applications
  • Improved the memory safety during omnitrace_finalize()
    • new modifications guarantee that when tim::manager::instance() on main thread is destroyed, omnitrace will finalize before
  • Improved some warning w/ roctracer
  • Improved the search for ROCP_METRICS and OMNITRACE_ROCPROFILER_LIBRARY
  • disable printing env by default
  • Attempted to improve the sampling shutdown

@jrmadsen
Raise default min number of instructions
8ac16de 
- Raise min instructions default to 1024 instead of 64
- Default value of 64 has demonstrated tendency to slow down real-life applications
@jrmadsen jrmadsen added omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) testing Extends/improves/modifies testing examples Adds new example or modifies existing example cmake Modifies the CMake build system labels Sep 30, 2022
@jrmadsen jrmadsen added libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library sampling Statistical sampling via interrupts roctracer GPU kernel tracing rocprofiler GPU kernel HW counters labels Sep 30, 2022
@jrmadsen jrmadsen merged commit 7d7a8f2 into ROCm:main Oct 1, 2022
@jrmadsen jrmadsen deleted the omnitrace-exe-default-num-instructions branch October 1, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake Modifies the CMake build system examples Adds new example or modifies existing example libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) rocprofiler GPU kernel HW counters roctracer GPU kernel tracing sampling Statistical sampling via interrupts testing Extends/improves/modifies testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen