Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding perfetto-validation-script #66

Merged
merged 17 commits into from
Jun 24, 2022
Merged

adding perfetto-validation-script #66

merged 17 commits into from
Jun 24, 2022

Conversation

ratamima
Copy link
Contributor

adding perfetto-validation-script

jrmadsen
jrmadsen requested changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@jrmadsen jrmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the file to validate-perfetto-proto.py.

I like the code to be formatted. Run pip install -U black and then black -t py38 -l 90 validate-perfetto-proto.py

tests/validate_perfetto.py Outdated Show resolved Hide resolved
tests/validate_perfetto.py Outdated Show resolved Hide resolved
tests/validate_perfetto.py Outdated Show resolved Hide resolved
tests/validate_perfetto.py Outdated Show resolved Hide resolved
tests/validate_perfetto.py Outdated Show resolved Hide resolved
tests/validate_perfetto.py Outdated Show resolved Hide resolved
@jrmadsen jrmadsen added perfetto Issue affects/involves perfetto features/capabilities testing Extends/improves/modifies testing labels Jun 22, 2022
ratamima and others added 13 commits June 23, 2022 12:45
@ratamima
adding perfetto-validation-script
2dd3def
@ratamima
Rename validation script
df5b1cb
@ratamima @jrmadsen
Update tests/validate_perfetto.py
342f396 
Co-authored-by: Jonathan R. Madsen <[email protected]>
@ratamima @jrmadsen
Update tests/validate_perfetto.py
9adc467 
Co-authored-by: Jonathan R. Madsen <[email protected]>
@ratamima @jrmadsen
Update tests/validate_perfetto.py
c1cef94 
Co-authored-by: Jonathan R. Madsen <[email protected]>
@ratamima @jrmadsen
Update tests/validate_perfetto.py
86234a7 
Co-authored-by: Jonathan R. Madsen <[email protected]>
@ratamima
addressed the edits in the validation script
0521d34
@ratamima
addressed the edits in the validation script
d3620e4
@jrmadsen @ratamima
Perfetto validation script (#1)
06e47cf 
* Fixed mismatch message in validate-timemory-json

* validate_perfetto.py -> validate-perfetto-proto.py

* Add python-source-validate-perfetto

- python-source-validate-perfetto uses validate-python-proto.py to validate perfetto output
- renamed python-source-check test to python-source-validate timemory

* Moved python-source-validate tests outside of cat command if block

- these tests don't rely on OMNITRACE_CAT_COMMAND

* CMake/CTest OMNITRACE_ADD_PYTHON_VALIDATION_TEST function

- generalized function for performing validation test with validate-{timemory-json,perfetto-proto}.py scripts
@jrmadsen
Print perfetto validation
d9dde73
@jrmadsen
Install perfetto python package in workflows
56a6c8e
@jrmadsen
cmake format
789a23d
@jrmadsen
Python formatting
e14d0c6
@jrmadsen jrmadsen added the omnitrace-python Involves the omnitrace python profiler executable label Jun 23, 2022
@jrmadsen jrmadsen merged commit cfa16cb into ROCm:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmadsen jrmadsen jrmadsen approved these changes

Assignees
No one assigned
Labels
omnitrace-python Involves the omnitrace python profiler executable perfetto Issue affects/involves perfetto features/capabilities testing Extends/improves/modifies testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ratamima @jrmadsen