Improved sampling performance #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jrmadsen
commented
Jun 29, 2022
•
jrmadsen
commented
- decreases the time required to sample
- fixes some filtering in the perfetto/timemory output
- backtrace::get() returns vector of string_view
- wrapped samples in perfetto "samples [omnitrace]" block
- samples in TID=0 in sampling mode are in separate thread row
jrmadsen
force-pushed
the
sampling-improvements
branch
from
dddd45f
to
6d7c31d
Compare
jrmadsen
force-pushed
the
sampling-improvements
branch
from
6d7c31d
to
1f57c3f
Compare
jrmadsen
added
sampling
- backtrace::get() returns vector of string_view - further performance improvements - tweaked _use_label - wrapped samples in perfetto "samples [omnitrace]" block - samples in TID=0 in sampling mode are in separate thread row
- fallback to to metric name if papi event info description not found - add perfetto sampling category
jrmadsen
force-pushed
the
sampling-improvements
branch
from
9b85c90
to
c6950aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.