-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix omnitrace print-* with libraries #94
Merged
jrmadsen
merged 17 commits into
ROCm:main
from
jrmadsen:omnitrace-print-available-library
Jul 21, 2022
Merged
fix omnitrace print-* with libraries #94
jrmadsen
merged 17 commits into
ROCm:main
from
jrmadsen:omnitrace-print-available-library
Jul 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmadsen
added
bug fix
Fixes a bug
omnitrace-instrument
Involves the omnitrace-instrument executable (binary instrumenter)
cmake
Modifies the CMake build system
Dyninst
Involves Dyninst
labels
Jul 19, 2022
jrmadsen
force-pushed
the
omnitrace-print-available-library
branch
from
July 19, 2022 07:19
71472c5
to
2face01
Compare
- fix ODR violations in utility/procfs
- uniform find_package for all ROCm-based libraries
- throw exception instead of std::exit
- some ELF execs "think" they are libraries so only assume rewrite + simulate + all-functions if filename looks like library - adds some test for --print-available -- <library>
jrmadsen
added
examples
Adds new example or modifies existing example
roctracer
GPU kernel tracing
rocm-smi
ROCm System Management Interface
rocprofiler
GPU kernel HW counters
timemory
Issue affects/involves timemory features/capabilities
submodule
Updates a git submodule
labels
Jul 19, 2022
- update module_function operator< and operator== - add function_signature operator< - refactor module_function ctor - revert some previous changes w.r.t. simulate and include_unninstr
- refactor module_function ctor to avoid segfaults - string_t -> std::string - replace std::string with std::string_view in some places - get_name(module_t*) - get_name(procedure_t*) - disable using both app_modules and app_functions - new option: --parse-all-modules to iterate over app_modules - removed some unused code w.r.t. debug info
- use dyninst insertInitCallback and insertFiniCallback if main not found - fixed all issues with segmentation faults in --simulate --all-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug fix
Fixes a bug
cmake
Modifies the CMake build system
Dyninst
Involves Dyninst
examples
Adds new example or modifies existing example
omnitrace-instrument
Involves the omnitrace-instrument executable (binary instrumenter)
rocm-smi
ROCm System Management Interface
rocprofiler
GPU kernel HW counters
roctracer
GPU kernel tracing
submodule
Updates a git submodule
timemory
Issue affects/involves timemory features/capabilities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omnitrace --print-available <type> -- <library>
--
for whether it is an executable or library--simulate --all-functions
which shows all functions even if they aren't instrumentable in binary-rewrite mode (but might be in runtime instrumentation)${PROJECT_BINARY_DIR}/lib
and exes are output to${PROJECT_BINARY_DIR}/bin