[Qt/Input] Improve pad_settings_dialog a bit #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
pad
branch
9 times, most recently
from
97aff58
to
ab14f57
Compare
Megamouse
changed the title
Megamouse
force-pushed
the
pad
branch
17 times, most recently
from
0b04995
to
3f0fc05
Compare
|
You've started a big and very welcome change. On archlinux, when I want to remap a button, it segfaults: |
danilaml
reviewed
Oct 25, 2017
| @@ -16,6 +17,9 @@ | |||
|
|
|||
| input_config input_cfg; | |||
|
|
|||
| inline std::string sstr(const QString& _in) { return _in.toUtf8().toStdString(); } | |||
There was a problem hiding this comment.
I think I've mentioned it before, but toUtf8() is unnecessary since according to the documentation it calls it during toStdString anyway.
and remove unnecessary usage of toUtf8
also fix threshold slider minimum also add ps button to all the handlers
based on danilaml code review and own debugging: Fixed path issue, <= 0 issue, some captures, const, axis with same codes. Adds a map to each device that differentiates negative and positive axis mappings. adjusted rest of the file to tabs (ListDevices and beginning of threadProc)
presumably better than the other
move bindpadtodevice down to keep consistency between handlers and not get crazy
use 0.5 of max value for threshold in pad dialog
|
With the PR Build. Some keys are shown as numbers Master |
|
restore defaults |
|
PS2 controller not working in this build . but it's works on 0.0.4-7049 |
isJuhn
pushed a commit
to isJuhn/rpcs3
that referenced
this pull request
Jan 19, 2018
* Input: further work on remapping Xinput and begin work on remapping DS4 * Input: Improve pad_settings_dialog a bit and begin Remapping for XInput * Input: begin evdev remapping and change all handlers to use cfg::string * Input: finish work on remapping evdev and some more crap * Input: finish work on remapping Xinput and DS4 * Input: add DS4 Colors to DS4 config * Input: Improve DS4 deadzone scaling Jarves made some mistakes, so I'll fix them in the follow up commit * Input: fix Jarves fixes on DS4 deadzone and remove unnecessary usage of toUtf8 * Input: add primitive batterychecks to XInput and DS4 * Input: add mmjoystick remapping * Input: Fix evdev and some Vibration issues * Input: adjust capabilities to fix stick input for games like LoS 2 also fix threshold slider minimum also add ps button to all the handlers * Input: Further evdev work based on danilaml code review and own debugging: Fixed path issue, <= 0 issue, some captures, const, axis with same codes. Adds a map to each device that differentiates negative and positive axis mappings. adjusted rest of the file to tabs (ListDevices and beginning of threadProc) * Input: use 20ms vibration update time for xbox one elite controllers. * Input: Fix return type of Clamp() * Input: Evdev Fix * Input: Evdev Optional GetNextButtonPress presumably better than the other * Input: review changes * Input: evdev: fix wrong index in axis handling move bindpadtodevice down to keep consistency between handlers and not get crazy * Input: evdev: fix expensive add_device in GetNextButtonPress * cleanup * Input: mmjoy: fix type * Input: evdev: final fixes * Input: evdev: exclude unnecessary buttons while mapping Xbox 360 or DS4 * Input: add deadzone preview by passing necessary values in callback use 0.5 of max value for threshold in pad dialog * Input: get rid of all-uppercase variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3616
fixes #3539
maybe #1283
last point of #3181
some of #3027